fix(css): ignore exportsOnly in local ident hashes - #15364
Conversation
Merging this PR will degrade performance by 2.29%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | rust@create_named_module_ids |
3.1 ms | 3.2 ms | -2.29% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing mattcosta7:fix/css-exports-only-local-ident-hash (f1baf23) with main (e8ecb52)2
Footnotes
-
47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(a9eda5a) during the generation of this report, so e8ecb52 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
Thanks. Some test cases are failing due to the hash changes and need to be updated. |
Summary
When building for SSR with CSS handling, the hashes end up differing because
exportsOnly: true | falseimpacts the hash generation.fixes #14786
exportsOnlyfrom CSS module local identifier hash inputsexportsOnlyin generator/runtime hashing where it affects emitted outputexportsOnly: false) and node (exportsOnly: true) builds with matching local-ident snapshotsRelated links
N/A
Validation
cargo check -p rspack_plugin_csscargo fmt --all -- --checkrspack_corecompilation withSIGTERM, including with one Cargo job and one rustc threadChecklist