Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Link): unify all the navigate and scroll behavior #1870

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Feb 21, 2025

Summary

  1. unify all the navigate and scroll behavior logic into one

  2. unify all <a /> to component, and comment that why we need to use <Link /> rather than <a />

Features related to scroll

  1. inCurrentPage: toc click
toc.mp4
  1. inCurrentPage: anchor click
anchor.mp4
  1. inCurrentSite
currentsite.mp4
  1. hashChange
hash.chagne.mp4

Related Issue

#1856

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 7fa3d4b
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67b837080f99fb00088ee3b0
😎 Deploy Preview https://deploy-preview-1870--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🔴 down 8 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter changed the title refactor(Link): unify all the scroll logic refactor(Link): unify all the navigate and scroll behavior Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant