fix(core): Fix an issue where llms.txt was not generated when locales was not set #2866
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where llms.txt was not generated when locales was not configured. The fix ensures that the default language is always included in the list of languages to generate llms.txt files for, even when no additional locales are configured.
Key Changes:
- Creates a Set containing both the default language and all configured languages
- Uses this Set to ensure at least the default language is processed when generating
llms.txtfiles
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const langs = new Set([defaultLang, ...routeService.getLangs()]); | ||
| await Promise.all( | ||
| routeService.getLangs().map(async lang => { | ||
| langs.values().map(async lang => { |
There was a problem hiding this comment.
The Set.values() method returns an iterator, not an array. The .map() method cannot be called directly on an iterator. This will cause a runtime error.
To fix this, you should convert the Set to an array first:
await Promise.all(
Array.from(langs).map(async lang => {Alternatively, you could use:
await Promise.all(
[...langs].map(async lang => {| langs.values().map(async lang => { | |
| [...langs].map(async lang => { |
1 participant
Summary
If locales is not set in the config, getLangs returns an empty array.
As a result, llms.txt was not being generated.
Related Issue
Checklist