Remove impossible VarDCT block size requirements#9
Open
foolip wants to merge 1 commit into
Open
Conversation
Member
Author
|
@hjanuschka is 2×2 tested? I see that vardct-small-blocks-reftest.html uses 8x8_noise.png which is larger... cc @veluca93 who told me 2×2 is really 8×8 in disguise. |
|
FWIW I'm not sure how changing block size would affect a browser integration, so I don't really see the point of this kind of tests :-) |
Member
Author
|
@veluca93 perhaps I went to far, but the idea was a smoke test touching the high-level features of the format, so that serious bugs in an independent implementation of a JPEG XL decoder are spotted. But I agree that it's very unlikely that the block sizes are even known to the browser in any sensible architecture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6.