Use more specific fuzzy matching limits for 2d.composite.grid tests #49107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are all implemented as a single parameterized test. The the fuzzy matching was defined in the base test definition, which means that all variants of the parameterized tests we using the same fuzzy config. This unfortunately required all the variants to share the same worse-case fuzzy matching limits. With a little Jinja templating, we can be more granular with how we specify that config. In this CL, the fuzzy config is specified using a map that is keyed based on the variant name, allowing each variant to have different config. This will be useful in a follow-up CL where adding blur to the shadow tests will further increase the difference between the fuzzy matching limits of different variants. Bug: 364549423 Change-Id: I20ada8d1b1a97b07b1a6eb5c4b3b98a8c8fcf9ac
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5999276
branch
from
fecd861
to
421d2e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are all implemented as a single parameterized test. The
the fuzzy matching was defined in the base test definition, which means
that all variants of the parameterized tests we using the same fuzzy
config. This unfortunately required all the variants to share the same
worse-case fuzzy matching limits.
With a little Jinja templating, we can be more granular with how we
specify that config. In this CL, the fuzzy config is specified using a
map that is keyed based on the variant name, allowing each variant to
have different config.
This will be useful in a follow-up CL where adding blur to the shadow
tests will further increase the difference between the fuzzy matching
limits of different variants.
Bug: 364549423
Change-Id: I20ada8d1b1a97b07b1a6eb5c4b3b98a8c8fcf9ac
Reviewed-on: https://chromium-review.googlesource.com/5999276
WPT-Export-Revision: 82d430883b523daadb9185c8035f795845786352