subtlecrypto: Don't throw exceptions twice when converting to Algorithm object #49141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes match statements like
These don't cause issues if
Algorithm::new
returnsOk(ConversionResult::Failure
, but in the case ofErr(())
the implementation already calledthrow_type_error
and we must not throw an additional Syntax error, otherwise we'll crash.Luckily, this case is already handled elsewhere by the
value_from_js_object
macro.Reviewed in servo/servo#34239