compositing: Move image output and shutdown management out of the compositor #50836
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Feb 20, 2025
|
⛔ The downstream PR has merged (servo/servo#35538), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
servo-wpt-sync
added
the
stale-servo-export
…positor This is a step toward the renderer-per-WebView goal. It moves various details out of `IOCompositor`. - Image output: This is moved to servoshell as now applications can access the image contents of a `WebView` via `RenderingContext::read_to_image`. Most options for this are moved to `ServoShellPreferences` apart from `wait_for_stable_image` as this requires a specific kind of coordination in the `ScriptThread` that is also very expensive. Instead, paint is now simply delayed until a stable image is reached and `WebView::paint()` returns a boolean. Maybe this can be revisited in the future. - Shutdown: Shutdown is now managed by libservo itself. Shutdown state is shared between the compositor and `Servo` instance. In the future, this sharing might be unecessary. - `CompositeTarget` has been removed entirely. This no longer needs to be passed when creating a Servo instance. Co-authored-by: Ngo Iok Ui (Wu Yu Wei) <[email protected]> Signed-off-by: Martin Robinson <[email protected]>
mrobinson
force-pushed
the
servo_export_35538
branch
from
c1b89da to
e58af1f
Compare
This was referenced Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step toward the renderer-per-WebView goal. It moves various
details out of
IOCompositor.access the image contents of a
WebViewviaRenderingContext::read_to_image. Most options for this are moved toServoShellPreferencesapart fromwait_for_stable_imageas thisrequires a specific kind of coordination in the
ScriptThreadthat isalso very expensive. Instead, paint is now simply delayed until a
stable image is reached and
WebView::paint()returns a boolean.Maybe this can be revisited in the future.
is shared between the compositor and
Servoinstance. In the future,this sharing might be unecessary.
This change also allows saving others types of image output just as JPEG.
Co-authored-by: Ngo Iok Ui (Wu Yu Wei) [email protected]
Signed-off-by: Martin Robinson [email protected]
Reviewed in servo/servo#35538