Permissions: add missing tests #50850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for edge cases, event model, revocation, and worker permissions.
|
Get Gemini to do the review 😂 |
miketaylr
approved these changes
Feb 21, 2025
| await Promise.resolve(); | ||
|
|
||
| // If we got no event, pass | ||
| // Cleanup |
There was a problem hiding this comment.
nit: This // Cleanup seems out of place.
| assert_equals(status.state, 'granted', 'State should now be "granted"'); | ||
| assert_array_equals( | ||
| results, | ||
| ['.onchange-fired', 'addEventListener-fired'].sort(), |
There was a problem hiding this comment.
nit: why does .onchange-fired start with . but addEventListener-fired doesn't?
| ); | ||
|
|
||
| // Cleanup | ||
| status.onchange = null; |
There was a problem hiding this comment.
nit: if you're doing this, do you want to removeEventListener as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for edge cases, event model, revocation, and worker permissions.
Closes w3c/permissions#460