Consolidate reference_file and is_test_reference into a single param #50864
+17
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Canvas WPT test generator was using two variables to control how a
test file links to it's reference file: 'reference_file' and
'is_test_reference'. In the context of documenting all parameters,
having to explain why we have two different parameters to do this one
thing is awkward. The logic and documentation will be simpler by using a
single 'reference_file_link' parameter.
Bug: 393561071
Change-Id: Id4523455f72ceb94684799cd672d11d87c106653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6219871
Reviewed-by: Andres Ricardo Perez <[email protected]>
Commit-Queue: Jean-Philippe Gravel <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1423298}