Allow multi-files variants to have no parameters in canvas WPT generator #50868
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was already possible to have variants without parameters, but it was
only working for single-file variant layout. This CL fixed it for
multi-files, allowing tests like:
- name: 2d.example-empty-params
code: ctx.globalCompositeOperation = {{ variant_name }};
variants:
- source-over:
source-in:
source-out:
Change-Id: Ibf4584cb693f8e2aa2a1dc432baf303c98812cbe
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6227183
branch
from
bfec082 to
e76fec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was already possible to have variants without parameters, but it was
only working for single-file variant layout. This CL fixed it for
multi-files, allowing tests like:
code: ctx.globalCompositeOperation = {{ variant_name }};
variants:
source-in:
source-out:
Change-Id: Ibf4584cb693f8e2aa2a1dc432baf303c98812cbe
Reviewed-on: https://chromium-review.googlesource.com/6227183
WPT-Export-Revision: 8079297364989c172fd4cd1f73df1f47824d1e68