[WPT] Prefetch + ServiceWorker: modifying requests #51676
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests for cases where speculation rules prefetch requests are intercepted and modified by ServiceWorker fetch handler. This should work similarly to non-modifying cases, except for `Sec-Purpose` header is dropped per spec. Even without ServiceWorker support, `assert_prefetched_without_sec_purpose()` doesn't fail. Corresponding tests will fail (without ServiceWorker support) after https://chromium-review.googlesource.com/c/chromium/src/+/6364354 by checking if the requests before modification has the Sec-Purpose header. Bug: 40947546, 404573971 Change-Id: I0813039dad140f493366d66ae46f54d6ae307a4e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for cases where speculation rules prefetch requests are
intercepted and modified by ServiceWorker fetch handler.
This should work similarly to non-modifying cases, except for
Sec-Purposeheader is dropped per spec.Even without ServiceWorker support,
assert_prefetched_without_sec_purpose()doesn't fail. Correspondingtests will fail (without ServiceWorker support) after
https://chromium-review.googlesource.com/c/chromium/src/+/6364354 by
checking if the requests before modification has the Sec-Purpose header.
Bug: 40947546, 404573971
Change-Id: I0813039dad140f493366d66ae46f54d6ae307a4e
Reviewed-on: https://chromium-review.googlesource.com/6180512
WPT-Export-Revision: 15c2772e519c1a4c76f41ccd839cfaae86069860