perf: batch insert attemptDetail #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
vm-001
force-pushed
the
perf/batch-insert-attempt-detail
branch
11 times, most recently
from
7fb42c9 to
31940e1
Compare
webhookx-x
force-pushed
the
perf/batch-insert-attempt-detail
branch
from
31940e1 to
260b074
Compare
cchenggit
approved these changes
Mar 23, 2025
| @@ -446,3 +440,40 @@ func listEndpointPlugins(ctx context.Context, db *db.DB, endpointId string) ([]* | |||
| } | |||
| return *plugins, err | |||
| } | |||
|
|
|||
| func (w *Worker) consumeAttemptDetails() { | |||
There was a problem hiding this comment.
nitpicking: consider graceful shutdown when context done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the attempt_details insertion performance.
texttype to get a slight performance improvementchannelas queue to implement batch insertion