feature: make pinned article shake if wanted#5831
Open
magnusbrecke wants to merge 1 commit intomasterfrom
Open
feature: make pinned article shake if wanted#5831magnusbrecke wants to merge 1 commit intomasterfrom
magnusbrecke wants to merge 1 commit intomasterfrom
Conversation
2 tasks
sondrejk
reviewed
Jan 22, 2026
| item={pinned} | ||
| url={itemUrl(pinned)} | ||
| meta={renderMeta(pinned)} | ||
| wiggle={pinned && isArticle(pinned) ? pinned.wiggle : false} |
Contributor
There was a problem hiding this comment.
Could you explain what this line does?
What is isArticle(pinned) and why is it anded with pinned?
(I'm just curious)
Contributor
Author
There was a problem hiding this comment.
Here I am checking if there exists a pinned "element" which could be more than just an article, and then checking if the pinned "element" is an article. If both true, wiggle will be pinned.wiggle which can be either true or false, chosen in the edit or create article shown in the video, and if not both are true, wiggle will be false.
|
|
||
| <Field | ||
| label="Wiggle på forsiden" | ||
| name="wiggle" |
Contributor
There was a problem hiding this comment.
wiggle??? what the heck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Should be an option to wiggle pinned article to get some attention to it on the front page, but only for authenticated users.
Result
Skjermopptak.2026-01-20.kl.14.33.37.mov
Testing
Resolves ABA-1618
Related backend PR: