This repository was archived by the owner on Dec 22, 2020. It is now read-only.
refactor: apply webpack defaults #21
Merged
+4,867
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage ? 83.33%
=========================================
Files ? 2
Lines ? 6
Branches ? 0
=========================================
Hits ? 5
Misses ? 1
Partials ? 0
Continue to review full report at Codecov.
|
bebraw
reviewed
Apr 9, 2017
src/index.js
Outdated
| @@ -4,7 +4,7 @@ | |||
| */ | |||
| import JSON5 from 'json5'; | |||
|
|
|||
| function Json5Plugin(source) { | |||
| function Json5Loader(source) { | |||
| if (this.cacheable) { | |||
There was a problem hiding this comment.
this.cacheable can be dropped I think.
bebraw
approved these changes
Apr 9, 2017
michael-ciniawsky
suggested changes
Apr 9, 2017
src/index.js
Outdated
| throw new Error('Error using JSON5 parsing'); | ||
| } | ||
|
|
||
| this.values = [value]; |
There was a problem hiding this comment.
This can be dropped aswell, if I remember right (webpack =< v0.6 or something like that :))
src/index.js
Outdated
| import JSON5 from 'json5'; | ||
|
|
||
| function Json5Loader(source) { | ||
| if (this.cacheable) { |
There was a problem hiding this comment.
Can be removed in webpack 2
package.json
Outdated
| "main": "dist/cjs.js", | ||
| "files": [ | ||
| "dist" | ||
| ], |
There was a problem hiding this comment.
"repository": {
"type": "git",
"url": "git+https://github.com/webpack-contrib/json5-loader.git"
},
"bugs": {
"url": "https://github.com/webpack-contrib/json5-loader/issues"
},
"homepage": "https://webpack.js.org",
Somewhere 😛
joshwiens
force-pushed
the
d3viant0ne-WebpackDefaults
branch
from
45f07ed to
99edde2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to be merged & released as a part of
1.0.0on a betadist-tagonce this has been finished and properly tested.BREAKING CHANGE:
Enforces NodeJS > 4.3 via engines
Closes #20