Skip to content

docs(plugins): remove all depreciated plugins #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 31, 2020

Conversation

snitin315
Copy link
Member

Fixes #3775

@vercel
Copy link

vercel bot commented Jun 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/1m7ifo5g0
✅ Preview: https://webpack-js-org-git-fork-snitin315-docs-plugins.webpack-docs.vercel.app

@snitin315
Copy link
Member Author

/cc @evilebottnawi

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, there is room to imrpove in another PR if you are willing to take on it

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you need to cleanup a link:

✖ FAIL load dist/plugins/extract-text-webpack-plugin
  | operator: load
  | expected: 200 dist/plugins/extract-text-webpack-plugin
  |   actual: ENOENT: no such file or directory, open '/home/travis/build/webpack/webpack.js.org/dist/plugins/extract-text-webpack-plugin/'
  |       at: dist/plugins/mini-css-extract-plugin/index.html:316:29 <a href="/plugins/extract-text-webpack-plugin/">...</a>

@snitin315
Copy link
Member Author

@EugeneHlushko Can you guide me for same?
This link seems to be inside plugins/_mini-css-extract-plugin which is being ignored by git?

@montogeek montogeek closed this Jun 16, 2020
@montogeek montogeek reopened this Jun 16, 2020
@montogeek
Copy link
Member

@snitin315 dist/plugins/extract-text-webpack-plugin doesn't exist anymore because this same PR deletes it.
Yes, file is ignored by git but still it is deployed, which mean you will need to remove it from mini-css-extract-plugin own README file.

@EugeneHlushko
Copy link
Member

✖ FAIL load dist/plugins/extract-text-webpack-plugin
  | operator: load
  | expected: 200 dist/plugins/extract-text-webpack-plugin
  |   actual: ENOENT: no such file or directory, open '/home/travis/build/webpack/webpack.js.org/dist/plugins/extract-text-webpack-plugin/'
  |       at: dist/loaders/extract-loader/index.html:10:53 <a href="/plugins/extract-text-webpack-plugin/">...</a>

@alexander-akait
Copy link
Member

/cc @snitin315 @EugeneHlushko @montogeek What is status? Maybe I can help?

@snitin315
Copy link
Member Author

Need to merge peerigon/extract-loader#87

@alexander-akait
Copy link
Member

alexander-akait commented Aug 6, 2020

I'm afraid it will never be merged, what is our workaround?

@snitin315
Copy link
Member Author

Need to investigate why our linting depends on other repositories readme files. /cc @montogeek

@alexander-akait
Copy link
Member

/cc @webpack/documentation-team friendly ping, developers still follow outdated projects and ask me why loaders/plugins are outdated, how I can help

@alexander-akait
Copy link
Member

/cc @EugeneHlushko friendly ping too

@montogeek
Copy link
Member

We could skip this link in particular.

@alexander-akait
Copy link
Member

@montogeek Can you take care about it? Thanks!

@alexander-akait
Copy link
Member

alexander-akait commented Aug 28, 2020

@montogeek @EugeneHlushko Please start to solve this issue ASAP, I get questions and error messages every day and it wastes my time

@chenxsan
Copy link
Member

chenxsan commented Aug 28, 2020

@snitin315 Could you try to update "lint:links" script in packages.json to this?:

"lint:links": "hyperlink -c 8 -r dist/index.html --canonicalroot https://webpack.js.org/ -i --skip /plugins/extract-text-webpack-plugin/ --skip https://img.shields.io --skip **/printable** --skip https://david-dm.org --skip https://codecov.io/gh --skip 'content-type-mismatch https://travis-ci.org' > internal-links.tap; cat internal-links.tap | tap-spot"

I've added this --skip /plugins/extract-text-webpack-plugin/ to skip it.

It fixed the CI failure in my test locally.

@snitin315
Copy link
Member Author

Thanks @chenxsan I will update.

@chenxsan
Copy link
Member

The current issue was gone as far as I see. Now there's another problem coming from source-map-loader:

  ✖ FAIL fragment-check dist/loaders/source-map-loader/index.html --> #url
  | operator: fragment-check
  | expected: id="url"
  |       at: dist/loaders/source-map-loader/index.html:1:14330 <a href="#url">...</a>

I've already submitted a pull request there webpack-contrib/source-map-loader#126, hopefully we can get the CI fixed soon once it is merged.

@snitin315
Copy link
Member Author

Can we skip all the /plugins/** & /loaders/** links?

@chenxsan
Copy link
Member

@snitin315 CI should pass now if you rerun it.

@chenxsan
Copy link
Member

I think lint:links script is good at catching those potential broken links. The problem here is we lint third-party plugins/loaders too, which might block CI if pull requests can't be merged there.

@snitin315 snitin315 closed this Aug 29, 2020
@snitin315 snitin315 reopened this Aug 29, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup it works now, indeed its hard given that readmes are outside of our codebase in webpack.js.org repo, but serving broken links never works well, thats why it was decided to keep it at error level, nobody would care if it was a warning

@EugeneHlushko EugeneHlushko merged commit 2e88e4c into webpack:master Aug 31, 2020
@EugeneHlushko
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove deprecated plugins from https://webpack.js.org/plugins/
5 participants