-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
docs(plugins): remove all depreciated plugins #3776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/1m7ifo5g0 |
/cc @evilebottnawi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, there is room to imrpove in another PR if you are willing to take on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, you need to cleanup a link:
✖ FAIL load dist/plugins/extract-text-webpack-plugin
| operator: load
| expected: 200 dist/plugins/extract-text-webpack-plugin
| actual: ENOENT: no such file or directory, open '/home/travis/build/webpack/webpack.js.org/dist/plugins/extract-text-webpack-plugin/'
| at: dist/plugins/mini-css-extract-plugin/index.html:316:29 <a href="/plugins/extract-text-webpack-plugin/">...</a>
@EugeneHlushko Can you guide me for same? |
@snitin315 |
|
/cc @snitin315 @EugeneHlushko @montogeek What is status? Maybe I can help? |
Need to merge peerigon/extract-loader#87 |
I'm afraid it will never be merged, what is our workaround? |
Need to investigate why our linting depends on other repositories readme files. /cc @montogeek |
/cc @webpack/documentation-team friendly ping, developers still follow outdated projects and ask me why loaders/plugins are outdated, how I can help |
/cc @EugeneHlushko friendly ping too |
We could skip this link in particular. |
@montogeek Can you take care about it? Thanks! |
@montogeek @EugeneHlushko Please start to solve this issue ASAP, I get questions and error messages every day and it wastes my time |
@snitin315 Could you try to update "lint:links": "hyperlink -c 8 -r dist/index.html --canonicalroot https://webpack.js.org/ -i --skip /plugins/extract-text-webpack-plugin/ --skip https://img.shields.io --skip **/printable** --skip https://david-dm.org --skip https://codecov.io/gh --skip 'content-type-mismatch https://travis-ci.org' > internal-links.tap; cat internal-links.tap | tap-spot" I've added this It fixed the CI failure in my test locally. |
Thanks @chenxsan I will update. |
The current issue was gone as far as I see. Now there's another problem coming from source-map-loader:
I've already submitted a pull request there webpack-contrib/source-map-loader#126, hopefully we can get the CI fixed soon once it is merged. |
Can we skip all the |
@snitin315 CI should pass now if you rerun it. |
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup it works now, indeed its hard given that readmes are outside of our codebase in webpack.js.org repo, but serving broken links never works well, thats why it was decided to keep it at error level, nobody would care if it was a warning
Thanks! |
Fixes #3775