storage: use s3v4 signature for presigning urls #2611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesn't seem to work with it
ikreymer
changed the title
- fix minio signing with v4 by using path-style addressing for minio - add 'access_addressing_style' to be able to choose virtual/path addressing for access endpoint - default to 'virtual', unless path is '/data/' for internal minio bucket, then use path - also make '/data/' configurable - remove isV4Signature, now always using v4 simplify running in any namespace with default settings: - don't hardcode 'local-minio.default' - in crawlers namespace, add a 'local-minio' externalName service which maps to the service in which the main namespace is
tw4l
approved these changes
May 19, 2025
ikreymer
added a commit
that referenced
this pull request
May 20, 2025
ikreymer
added a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use V4 ('s3v4') signature version for for all presigning URLs to support backblaze, fixes #2472
also simplify running in any namespace with default settings: