-
-
Notifications
You must be signed in to change notification settings - Fork 59
Add "Last Crawl Status" filter to workflows list #2902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a1e1d2e
to
649e8bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since workflows only do one crawl at a time, I think leaving off "Last" is still legible and more concise: "Crawl Status"? I don't feel too strongly about this, though, if the consensus is to keep it.
Yeah, I guess it depends whether we think of "crawl" here as "the process of crawling" (generalized) vs "an instance of this process of crawling" (specific). My impulse would be towards the latter, especially since we've got a list of crawls that you can see from the archived item page & from individual workflows. I worry that without "last" users might expect this to filter by statuses from all past crawls, or something like that. |
Could also be "Latest Crawl" to match the corresponding tab in the workflow? |
Oh true, I forgot we'd used "Latest" — I think that's slightly clearer (though slightly longer too), I'll update it. |
FYI we do mention in the user guide that workflow statuses are either inherited or their "own":
This makes me think just "Status" is the most accurate label, since that's how it's also labeled in the workflow detail view: ![]() |
Okay, I see your point, though I do still wonder if it's confusing in the info bar — I almost wonder if "Latest Crawl - Complete" would make more sense there too. That's out of scope of this pr though. For now, I wonder if we could eliminate the "status" part as well, and have the filter just say "Latest Crawl"...? I'm not sure, I feel like I could be convinced either way: the way it's explained in the docs makes just "Status" make more sense, but I do also kiiinda feel like that's confusing too, since it suggests that it's sort of a separate state from the latest crawl's state, which slightly conflicts with how it's displayed in the workflow's crawls list where both the workflow and the currently-running crawl have a state. |
Yeah that's fair. There's also this issue that hasn't been prioritized yet that proposes changing the workflows list columns to match the details, so we can reassess the filter label when we update the workflow columns. ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend changes look good!
Closes #2729
Changes
Adds a filter to the workflow list that allows filtering by last crawl state.
This filter includes all crawl states as options, as opposed to the archived item filter which only includes "finished" states.
Screenshot