misc backend profile fixes: #2973
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update inUse for profile list (fixes #2970) - ensure origins for existing profiles returns all origins - ensure proxyId and crawlerChannel when committing are set from the browser, not from API request internal improvements: - add crawlerChannel and proxyId to ProfileJob labels - convert labels to typed ProfileBrowserMetadata
tw4l
approved these changes
Nov 10, 2025
Member
tw4l
left a comment
tw4l
left a comment
There was a problem hiding this comment.
Tested locally, looks good. Would be nice to have some test coverage for inUse in the list endpoint, but I think we only currently apply profiles to workflows in the nightly tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inUsefor profile in list always false #2970)internal improvements: