Additional Profile Tests + Reset Profiles fix #2987
+123
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rowser, and not resetting
…Date for profiles after crawl finishes
tw4l
approved these changes
Nov 17, 2025
Member
tw4l
left a comment
tw4l
left a comment
There was a problem hiding this comment.
Thanks for adding these tests! Left one comment that would be good to address before merging I think, as it might bite us later.
Comment on lines
28
to
+29
| admin_crawl_id = None | ||
| admin_config_id = None |
Member
There was a problem hiding this comment.
I recognize admin_crawl_id has been this way for a bit already, but we should probably rename both of these globals, since they're named identically to pytest fixtures defined in conftest.py that are used all throughout our tests, including in this module. Seems like that would introduce potential for confusion or even unexpected behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick follow to #2973 - ensure that the origins are not added if profile is being reset.
tests: