Add per collection-index use_indexer_date_filter option#972
Open
VladimirPress wants to merge 2 commits intowebrecorder:mainfrom
Open
Add per collection-index use_indexer_date_filter option#972VladimirPress wants to merge 2 commits intowebrecorder:mainfrom
use_indexer_date_filter option#972VladimirPress wants to merge 2 commits intowebrecorder:mainfrom
Conversation
Adds a new per-collection configuration option use_indexer_date_filter. When enabled for a collection, pywb forwards from and to date parameters to the indexer, if present. This shifts date filtering to the indexer, reducing pywb CPU and memory usage, preventing OOM conditions, and lowering network traffic.
Author
|
I have tested the functionality of this change on my system. |
Member
|
One small request: can you rename it to |
Rename use_indexer_date_filter to use_remote_date_filter.
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new per collection-index configuration option
use_indexer_date_filter.When enabled for a collection, pywb forwards
fromandtodate parameters to the indexer, if present.This shifts date filtering to the indexer, reducing pywb CPU and memory usage, preventing OOM conditions, and lowering network traffic.
Unfortunately, I could not find an appropriate section in the documentation to add this parameter description.
Motivation and Context
This feature allows heavy date filtering to be offloaded to the indexer, which prevents pywb server overload and high memory usage for large collections.
Screenshots (if appropriate):
Types of changes
Checklist: