refactor: change announce
and announceList
#119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[X] Other, please explain:
announce
andannounceList
parametersWhat changes did you make? (Give an overview)
This PR:
announce
andannounceList
. The current code in master, depends onannounceList
being false to be able to use theopts.announce
; which is good for parsing the torrent. But since we are creating it, I think we should allow to set both values (with no dependency on being false).For example:
If we use
announce = "wss://example1.com"
andannounceList = [["wss://example2.com"]]
The current code in master, would ignore the value in
announce
. This PR adds theannounce
value toannounceList
.Which issue (if any) does this pull request address?
Not directly, but the issue seen in #118 would have had a better output. In that particular case (with the new changes), an invalid
announceList
will not throw an error and just discard the invalid trackers.Is there anything you'd like reviewers to focus on?