Refactor bound control - #1638
Open
hicom150 wants to merge 1 commit into
Open
Conversation
|
👋 We would appreciate it if you could provide us with more information about this issue. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
alxhotel
requested changes
Oct 1, 2022
| } | ||
| function setBounds (bounds) { | ||
| // X and Y not specified? By default, center on current screen | ||
| if (bounds.x === null && bounds.y === null) { |
Member
There was a problem hiding this comment.
bounds could still be null from the saved state of the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a small refactor to simplify a bit the bound control code.
isMininizedandisFullscreenbefore changing window sizesetContentBoundsasuseContentSizeis enabled