Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #138 (Incoherent UPDATE return for MySQL/MariaDB) #140

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

Soblow
Copy link
Contributor

@Soblow Soblow commented Mar 1, 2024

This MR fixes #138 , and also adds a few missing links in CHANGELOG.md .

Soblow added 3 commits March 1, 2024 11:33
…mand return is consistent with PostgreSQL

Signed-off-by: Soblow "Opale" Xaselgio <[email protected]>
Signed-off-by: Soblow "Opale" Xaselgio <[email protected]>
@Soblow
Copy link
Contributor Author

Soblow commented Mar 1, 2024

I can add some tests if you want though.

Copy link
Owner

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Having a test for this would be great (but it's not strictly required for merging)

@weiznich weiznich merged commit d02798c into weiznich:main Mar 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incoherence between Diesel and Diesel_async on MySQL/MariaDB connection (UPDATE return value)
2 participants