Change the GAV and package names for junit5 extensions to junit-jupiter. Provide OpenRewrite recipe for migration#329
Open
manovotn wants to merge 7 commits intoweld:masterfrom
Open
Change the GAV and package names for junit5 extensions to junit-jupiter. Provide OpenRewrite recipe for migration#329manovotn wants to merge 7 commits intoweld:masterfrom
manovotn wants to merge 7 commits intoweld:masterfrom
Conversation
Member
Author
|
I have added separate commits that:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #293
Having
junit5in the name wasn't the best choice; this PR follows up on the issue regarding JUnit 6 and will allow us to rename the artifact and packages to be JUnit agnostic, only relating to the jupiter engine it uses.We can then also use JUnit 6 as baseline (we are keeping 5.x ATM to not confuse users although we can run with both just fine).
Artifact ID changed from
junit5suffix tojunit-jupiter.junit5packages were changed tojunit.jupiter.The OpenRewrite recipe covers both of these changes and currently hardcodes 6.0.0.Final version which would be the next version for CDI 5/Weld7.
I have tried the recipe on a dummy project and that seems to work fine.
One thing it won't cover are custom service providers (custom enrichers) but those should be rare enough and simple to fix.