Move module from BackendConfig to BootArtefact
#1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the module name in the frontend as well as the backend. Since the configuration should specify "how" and not "what," this commit removes it from the configuration altogether. It is instead passed as an argument, like the input headers, and stored in the boot artifact.
|
Issue #1046 discusses moving input headers and output directory configuration into the configuration (stopping the "how not what" organization principle). Note that the module is a special case, however, because users should not be able to configure the module when using the Template Haskell API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the module name in the frontend as well as the backend. Since the configuration should specify "how" and not "what," this commit removes it from the configuration altogether. It is instead passed as an argument, like the input headers, and stored in the boot artifact.