[Feature/review] 업체 상세 리뷰 드로어 도입 및 Google 리뷰 출처 표기 적용#206
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the company review display by extracting the review list logic into a shared CompanyReviewListContent component, which is now utilized by both the main review page and a newly introduced CompanyReviewDrawer. The changes also include support for displaying review sources (e.g., Google Reviews) and adding localized strings for English, Japanese, and Korean. Feedback focuses on removing redundant client-side filtering that duplicates server-side logic, localizing the hardcoded "Google Reviews" label, and improving the "My Country Only" filter behavior when a user's country is unknown. Additionally, specific localization improvements were suggested for the Japanese and Korean translations of the "More" button.
| const filteredReviews = useMemo(() => { | ||
| let list = reviewList; | ||
|
|
||
| if (withPhotos) { | ||
| list = list.filter((review) => (review.image_urls?.length ?? 0) > 0); | ||
| } | ||
|
|
||
| if (myCountryOnly && country) { | ||
| list = list.filter((review) => review.customer_country === country); | ||
| } | ||
|
|
||
| return list; | ||
| }, [reviewList, withPhotos, myCountryOnly, country]); |
There was a problem hiding this comment.
The local filtering logic here is redundant because the queryParams (lines 32-41) already include these filter criteria (with_photos, my_country_only, country), which are passed to the infinite query. Since this is an infinite scroll implementation, client-side filtering can lead to inconsistent results or empty pages if the server-side pagination doesn't align perfectly with the client-side filter. It is better to rely solely on the server-side filtering provided by the API.
const filteredReviews = reviewList;
| "reviewImageAlt": "리뷰 이미지 {index}", | ||
| "googleSourceNotice": "* 이 리뷰는 {source}에서 수집되었어요.", | ||
| "moreOptions": "더보기", | ||
| "viewMore": "More", |
There was a problem hiding this comment.
The translation for viewMore is set to "More" in Korean. Usually, "더보기" is more appropriate for a Korean localized UI. Please check if this was intended or if it should be translated.
| "viewMore": "More", | |
| "viewMore": "더보기", |
| "reviewImageAlt": "レビュー画像 {index}", | ||
| "googleSourceNotice": "* このレビューは{source}から収集されました。", | ||
| "moreOptions": "その他のオプション", | ||
| "viewMore": "More", |
There was a problem hiding this comment.
The translation for viewMore is set to "More" in Japanese. Usually, "もっと見る" or "詳細" is more appropriate. Please check if this was intended.
| "viewMore": "More", | |
| "viewMore": "もっと見る", |
|
|
||
| const GUEST_REVIEW_SOURCE_LABELS: Record<GuestReviewSource, string | null> = { | ||
| in_app: null, | ||
| google: 'Google Reviews', |
There was a problem hiding this comment.
Hardcoding the label "Google Reviews" here prevents it from being translated. Since this label is used within a translated string in the Card component, it should also be managed via the i18n system to ensure consistency across different languages (e.g., "Google 리뷰" in Korean).
| type="button" | ||
| css={[filterToggle, myCountryOnly && filterToggleActive]} | ||
| onClick={() => setMyCountryOnly((prev) => !prev)} | ||
| > | ||
| <Check width={14} height={14} /> | ||
| <Text typo="button_S" color={myCountryOnly ? 'primary50' : 'text_secondary'}> | ||
| {t('myCountryOnly')} | ||
| </Text> | ||
| </button> |
There was a problem hiding this comment.
The "My Country Only" filter button is active even when the user's country is unknown (e.g., when not logged in). Clicking it in this state won't change the results because country is undefined in queryParams. Consider disabling or hiding this filter if country is not available.
1 participant
📝 관련 문서 레퍼런스
💻 주요 변경 사항은 무엇인가요?
📚 추가된 라이브러리
📱 결과 화면 (선택)
🙇 코드 리뷰 중점사항, 예상되는 문제점 (선택)