Add support for older redis versions #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrubabalau
force-pushed
the
redis6.2-support
branch
from
beea908 to
328548c
Compare
sobolevn
reviewed
Oct 25, 2022
|
|
||
| async with self._lock: | ||
| current_rate = await self._run_pipeline(cache_key, pipeline) | ||
| redis_version = await self.redis_version() |
There was a problem hiding this comment.
Can we do this earlier? We don't need to query this every time. We only need this once per app.
| redis_version = await self.redis_version() | ||
|
|
||
| if int(redis_version.split('.')[0]) < 7: | ||
| current_rate, *_ = await pipeline.incr(cache_key).execute() |
There was a problem hiding this comment.
It feels like you execute a pipeline twice. This might not be safe due to race conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.