Skip to content

Do not freak out on not supported messages#127

Open
spoutn1k wants to merge 1 commit into
mainfrom
spoutn1k/EX-13229
Open

Do not freak out on not supported messages#127
spoutn1k wants to merge 1 commit into
mainfrom
spoutn1k/EX-13229

Conversation

@spoutn1k

Copy link
Copy Markdown
Contributor

The collector is crashing and burning at a client's whose system is configured with:

[fs.data.mdt]
tunefs_opts = "--param mdt.quota_type=ug"
"data.quota.mdt" = "ugp"

The mismatch between the params causes this in lctl:

#lctl get_param osd-*.*.quota_slave.acct_project
osd-ldiskfs.data-MDT0000.quota_slave.acct_project=not supported
osd-ldiskfs.data-OST0000.quota_slave.acct_project=not supported
osd-ldiskfs.data-OST0001.quota_slave.acct_project=not supported

Which is not supported in turn by us.

@codecov

codecov Bot commented Jan 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.57%. Comparing base (b133c34) to head (ba56b90).

Files with missing lines Patch % Lines
lustre-collector/src/osd_parser.rs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   94.57%   94.57%   -0.01%     
==========================================
  Files          46       46              
  Lines        6107     6116       +9     
  Branches     6107     6116       +9     
==========================================
+ Hits         5776     5784       +8     
  Misses        256      256              
- Partials       75       76       +1     
Flag Coverage Δ
2_14_0_ddn133 35.61% <56.25%> (-0.03%) ⬇️
2_14_0_ddn145 37.38% <56.25%> (-0.04%) ⬇️
all-tests 94.57% <93.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jan 23, 2026

Copy link
Copy Markdown

🐰 Bencher Report

Branchspoutn1k/EX-13229
Testbedci-runner

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkD1 Miss Ratemisses (%)D1mrmisses (reads) x 1e3D1mwmisses (writes) x 1e3DLmrmisses (reads)DLmwmisses (writes) x 1e3Drreads x 1e6Dwwrites x 1e6Estimated Cyclescycles x 1e6I1 Miss Ratemisses (%)I1mrmisses (reads) x 1e3ILmrmisses (reads)InstructionsBenchmark Result
instructions x 1e6
(Result Δ%)
Lower Boundary
instructions x 1e6
(Limit %)
Upper Boundary
instructions x 1e6
(Limit %)
L1 Hit Ratehits (%)L1 Hitshits x 1e6LL Hit Ratehits (%)LL Hitshits x 1e3LL Miss Ratemisses (%)LLd Miss Ratemisses (%)LLi Miss Ratemisses (%)RAM Hit Ratehits (%)RAM Hitshits x 1e3Total read+writereads/writes x 1e6
lustre_metrics::memory_benches::bench_encode_lustre_metrics with_setup:generate_records()📈 view plot
⚠️ NO THRESHOLD
0.93 %📈 view plot
⚠️ NO THRESHOLD
25.15 reads x 1e3📈 view plot
⚠️ NO THRESHOLD
9.16 writes x 1e3📈 view plot
⚠️ NO THRESHOLD
125.00 reads📈 view plot
⚠️ NO THRESHOLD
6.66 writes x 1e3📈 view plot
⚠️ NO THRESHOLD
2.47 x 1e6📈 view plot
⚠️ NO THRESHOLD
1.23 x 1e6📈 view plot
⚠️ NO THRESHOLD
14.82 x 1e6📈 view plot
⚠️ NO THRESHOLD
0.01 %📈 view plot
⚠️ NO THRESHOLD
1.05 reads x 1e3📈 view plot
⚠️ NO THRESHOLD
899.00 reads📈 view plot
🚷 view threshold
10.75 x 1e6
(-20.13%)Baseline: 13.46 x 1e6
2.32 x 1e6
(21.56%)
24.60 x 1e6
(43.70%)
📈 view plot
⚠️ NO THRESHOLD
99.76 %📈 view plot
⚠️ NO THRESHOLD
14.41 x 1e6📈 view plot
⚠️ NO THRESHOLD
0.19 %📈 view plot
⚠️ NO THRESHOLD
27.68 x 1e3📈 view plot
⚠️ NO THRESHOLD
0.05 %📈 view plot
⚠️ NO THRESHOLD
0.18 %📈 view plot
⚠️ NO THRESHOLD
0.01 %📈 view plot
⚠️ NO THRESHOLD
0.05 %📈 view plot
⚠️ NO THRESHOLD
7.68 x 1e3📈 view plot
⚠️ NO THRESHOLD
14.45 x 1e6
🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Jan 23, 2026

Copy link
Copy Markdown

🐰 Bencher Report

Branchspoutn1k/EX-13229
Testbedci-runner
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Lower Boundary
nanoseconds (ns)
(Limit %)
Upper Boundary
nanoseconds (ns)
(Limit %)
parse_benchmarks/combine_performance📈 view plot
🚷 view threshold
130,150,000.00 ns
(-49.05%)Baseline: 255,433,388.89 ns
-722,324,855.82 ns
(-554.99%)
1,233,191,633.59 ns
(10.55%)
🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Jan 23, 2026

Copy link
Copy Markdown

🐰 Bencher Report

Branchspoutn1k/EX-13229
Testbedci-runner

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
Benchmarkavg_runtime_rss_mibMeasure (MiB)avg_runtime_virtual_mibMeasure (MiB)end_rss_mibMeasure (MiB)end_virtual_mibMeasure (MiB)memory_growth_mibMeasure (MiB)peak_over_start_rss_ratioMeasure (units)peak_over_start_virtual_ratioMeasure (units)peak_rss_mibBenchmark Result
Measure (MiB)
(Result Δ%)
Lower Boundary
Measure (MiB)
(Limit %)
Upper Boundary
Measure (MiB)
(Limit %)
peak_virtual_mibMeasure (MiB)start_rss_mibMeasure (MiB)start_virtual_mibMeasure (MiB)virtual_growth_mibMeasure (MiB)
scrape_allocations📈 view plot
⚠️ NO THRESHOLD
40.49 MiB📈 view plot
⚠️ NO THRESHOLD
839.32 MiB📈 view plot
⚠️ NO THRESHOLD
40.55 MiB📈 view plot
⚠️ NO THRESHOLD
839.39 MiB📈 view plot
⚠️ NO THRESHOLD
0.30 MiB📈 view plot
⚠️ NO THRESHOLD
1.03 units📈 view plot
⚠️ NO THRESHOLD
1.02 units📈 view plot
🚷 view threshold
41.75 MiB
(-46.91%)Baseline: 78.65 MiB
-137.61 MiB
(-329.57%)
294.91 MiB
(14.16%)
📈 view plot
⚠️ NO THRESHOLD
878.92 MiB📈 view plot
⚠️ NO THRESHOLD
40.25 MiB📈 view plot
⚠️ NO THRESHOLD
834.04 MiB📈 view plot
⚠️ NO THRESHOLD
5.35 MiB
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant