EX-14926: Remove duplicate recovery_status records in lustre-collector - #150
Open
yangx-jy wants to merge 1 commit into
Open
EX-14926: Remove duplicate recovery_status records in lustre-collector#150yangx-jy wants to merge 1 commit into
yangx-jy wants to merge 1 commit into
Conversation
yangx-jy
requested review from
breuhan,
johnsonw,
jparris,
palash3 and
utopiabound
as code owners
July 9, 2026 06:33
|
Bencher Report| Project | lustrefs-exporter |
| Branch | xyang/EX-14926 |
| Testbed | ci-runner |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| parse_benchmarks/combine_performance | 📈 view plot 🚷 view threshold | 124,480,000.00 ns(-39.46%)Baseline: 205,627,392.86 ns | -556,225,484.91 ns (-446.84%) | 967,480,270.62 ns (12.87%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 94.60% 94.86% +0.25%
==========================================
Files 46 46
Lines 6671 6638 -33
Branches 6671 6638 -33
==========================================
- Hits 6311 6297 -14
+ Misses 271 254 -17
+ Partials 89 87 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| Project | lustrefs-exporter |
| Branch | xyang/EX-14926 |
| Testbed | ci-runner |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
- L1 Hits (hits)
- D1mr (misses (reads))
- DLmr (misses (reads))
- Dr (reads)
- LLd Miss Rate (misses (%))
- ILmr (misses (reads))
- I1mr (misses (reads))
- LL Miss Rate (misses (%))
- LL Hit Rate (hits (%))
- LLi Miss Rate (misses (%))
- DLmw (misses (writes))
- L1 Hit Rate (hits (%))
- D1 Miss Rate (misses (%))
- RAM Hit Rate (hits (%))
- Estimated Cycles (cycles)
- Total read+write (reads/writes)
- I1 Miss Rate (misses (%))
- D1mw (misses (writes))
- LL Hits (hits)
- RAM Hits (hits)
- Dw (writes)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | D1 Miss Rate | misses (%) | D1mr | misses (reads) x 1e3 | D1mw | misses (writes) x 1e3 | DLmr | misses (reads) | DLmw | misses (writes) x 1e3 | Dr | reads x 1e6 | Dw | writes x 1e6 | Estimated Cycles | cycles x 1e6 | I1 Miss Rate | misses (%) | I1mr | misses (reads) x 1e3 | ILmr | misses (reads) | Instructions | Benchmark Result instructions x 1e6 (Result Δ%) | Lower Boundary instructions x 1e6 (Limit %) | Upper Boundary instructions x 1e6 (Limit %) | L1 Hit Rate | hits (%) | L1 Hits | hits x 1e6 | LL Hit Rate | hits (%) | LL Hits | hits x 1e3 | LL Miss Rate | misses (%) | LLd Miss Rate | misses (%) | LLi Miss Rate | misses (%) | RAM Hit Rate | hits (%) | RAM Hits | hits x 1e3 | Total read+write | reads/writes x 1e6 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| lustre_metrics::memory_benches::bench_encode_lustre_metrics with_setup:generate_records() | 📈 view plot | 0.93 % | 📈 view plot | 25.48 reads x 1e3 | 📈 view plot | 9.42 writes x 1e3 | 📈 view plot | 133.00 reads | 📈 view plot | 6.41 writes x 1e3 | 📈 view plot | 2.49 x 1e6 | 📈 view plot | 1.24 x 1e6 | 📈 view plot | 14.90 x 1e6 | 📈 view plot | 0.01 % | 📈 view plot | 1.12 reads x 1e3 | 📈 view plot | 953.00 reads | 📈 view plot 🚷 view threshold | 10.80 x 1e6(-14.91%)Baseline: 12.69 x 1e6 | 3.25 x 1e6 (30.13%) | 22.13 x 1e6 (48.80%) | 📈 view plot | 99.75 % | 📈 view plot | 14.50 x 1e6 | 📈 view plot | 0.20 % | 📈 view plot | 28.53 x 1e3 | 📈 view plot | 0.05 % | 📈 view plot | 0.18 % | 📈 view plot | 0.01 % | 📈 view plot | 0.05 % | 📈 view plot | 7.49 x 1e3 | 📈 view plot | 14.53 x 1e6 |
yangx-jy
force-pushed
the
xyang/EX-14926
branch
2 times, most recently
from
July 9, 2026 07:56
ac8e3af to
5698baa
Compare
utopiabound
previously approved these changes
Jul 12, 2026
spoutn1k
previously approved these changes
Jul 13, 2026
yangx-jy
force-pushed
the
xyang/EX-14926
branch
from
August 11, 2026 01:54
5698baa to
04c3587
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recovery_status is already collected and parsed by the main lctl path (get_lctl_output via parser::params()/parser::parse()).
Fixes: ee3df94 ("Add recover_status parser lustrefs_exporter (#118)")