Skip to content

Improve readability. maybe..#1326

Open
zhangenming wants to merge 1 commit into
whatwg:mainfrom
zhangenming:patch-1
Open

Improve readability. maybe..#1326
zhangenming wants to merge 1 commit into
whatwg:mainfrom
zhangenming:patch-1

Conversation

@zhangenming

@zhangenming zhangenming commented Nov 19, 2024

Copy link
Copy Markdown

At first I was a little confused when I read the words and it felt strange
I'm trying to make it a little more readable in the hope that it helps

before:
image

after:
image


Preview | Diff

@annevk

annevk commented Nov 19, 2024

Copy link
Copy Markdown
Member

While I appreciate the suggestion, this makes it less consistent with the language we use elsewhere.

An alternative that could maybe work is to rename the variables to nodeA and nodeB to distinguish them more from the leading "A". WDYT?

@zhangenming

Copy link
Copy Markdown
Author

image

@zhangenming

Copy link
Copy Markdown
Author

how about use 'the' word
image

@zhangenming

zhangenming commented Nov 19, 2024

Copy link
Copy Markdown
Author

this makes it less consistent with the language we use elsewhere.

Either solution seems to require global modification

@annevk

annevk commented Nov 19, 2024

Copy link
Copy Markdown
Member

"The" has the same issue as removing "A". I'm not sure what you mean with global modification for my solution? I don't think there's that many variables named "A"? Or perhaps I misunderstood the problem?

@zhangenming

zhangenming commented Nov 19, 2024

Copy link
Copy Markdown
Author

<var>A</var> search result : 44

@zhangenming

Copy link
Copy Markdown
Author

a node a // strange
a node nodeA // redundancy
the node a // better
node a // best

Whichever option is chosen
Will causethis makes it less consistent with the language we use elsewhere.
So i think the whole thing needs to be revised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants