-
Notifications
You must be signed in to change notification settings - Fork 319
Update element adoption logic for scoped registry #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dom.bs
Outdated
| <a for=Element>custom element registry</a> is null or is equal to <var>document</var>'s | ||
| <a>effective global custom element registry</a>, then set <var>inclusiveDescendant</var>'s | ||
| <a for=Element>custom element registry</a> to <var>inclusiveDescendant</var>'s | ||
| <a for=tree>parent</a>'s <a for=Element>custom element registry</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not using the "effective global custom element registry" strategy discussed? It's not clear to me this is the same or why we need to be looking at document at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to use "effective global custom element registry" strategy as discussed. Was trying to see if I could get the point across with another approach but it seems like "effective global custom element registry" is still the better way to go. Lmk if I'm missing anything on this idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. We'll need tests next.
For the tests I'd like us to exercise some of the more complicated scenarios with some nodes having been assigned registries and others not, etc.
|
Just added some tests but I haven't fully verified them yet. Feel free to take a look. |
Fixing #1429 to make sure element is getting the correct scoped custom element registry upon adoption.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff