-
Notifications
You must be signed in to change notification settings - Fork 373
[WebDriver BiDi] emulated network offline #1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
annevk
merged 7 commits into
whatwg:main
from
sadym-chromium:sadym/emulation.setNetworkConditions
Oct 10, 2025
Merged
[WebDriver BiDi] emulated network offline #1852
annevk
merged 7 commits into
whatwg:main
from
sadym-chromium:sadym/emulation.setNetworkConditions
Oct 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
added a commit
to w3c/webdriver-bidi
that referenced
this pull request
Oct 7, 2025
First step addressing #776. * Fail all the intercepted requests, WebSocket and WebTransport. * Html spec: whatwg/html#11575 * Fetch spec: whatwg/fetch#1852
6 tasks
noamr
reviewed
Oct 8, 2025
sadym-chromium
commented
Oct 9, 2025
fetch.bs
Outdated
| </ol> | ||
| </div> | ||
|
|
||
| <p>A <dfn export>user agent is offline</dfn> when the user agent assumes it do not have network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annevk is it what you meant in whatwg/html#11575 (comment)?
annevk
reviewed
Oct 10, 2025
9669497 to
324a0cc
Compare
|
@annevk could you please merge if you don't have any no other concerns? |
annevk
approved these changes
Oct 10, 2025
Co-authored-by: Anne van Kesteren <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
annevk
approved these changes
Oct 10, 2025
|
Thanks @sadym-chromium! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If WebDriver BiDi emulated network offline condition, fail any outgoing fetch.
emulation.setNetworkConditions:offlineweb-platform-tests/wpt#55300emulation.setNetworkConditions:offlineGoogleChromeLabs/chromium-bidi#3819(See WHATWG Working Mode: Changes for more details.)
Preview | Diff