Skip to content

common: Add file sharing support#1025

Merged
thyal merged 5 commits into
mainfrom
thomas/PAN-2635-file-sharing
Jun 16, 2026
Merged

common: Add file sharing support#1025
thyal merged 5 commits into
mainfrom
thomas/PAN-2635-file-sharing

Conversation

@thyal

@thyal thyal commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Description

Adds file sharing support.

Summary:

Related Issue:

Testing

  1. pnpm build && pnpm dev
  2. Go to the Room Connection With File Sharing story
  3. join the room, try to share a file
  4. Verify that you get the "Not in a room session" error (this is expected)
  5. Join the same room from a different tab
  6. Verify that file sharing works both from the storybook tab and the room tab (share files both ways)
  7. Try with too many files > 10 and verify that it rejects with the error too_many_files
  8. Try with an unsupported file type and verify that it rejects with the error unsupported_file_type

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Additional Information

@changeset-bot

changeset-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0eb495d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@whereby.com/browser-sdk Minor
@whereby.com/core Minor
@whereby.com/media Patch
@whereby.com/assistant-sdk Patch
@whereby.com/react-native-sdk Patch
@whereby.com/audio-denoiser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thyal thyal force-pushed the thomas/PAN-2635-file-sharing branch 3 times, most recently from 3dadd8d to cbc46cc Compare June 10, 2026 10:50
@thyal thyal marked this pull request as ready for review June 10, 2026 11:12
@thyal thyal requested a review from a team June 10, 2026 11:12

@richtrwhereby richtrwhereby left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, clean work here 💯

Tested and works for me. A couple of minor non-blocking comments to consider but LGTM and approved ✅

Comment thread packages/core/src/redux/slices/signalConnection/index.ts
Comment thread packages/core/src/redux/slices/fileShare.ts Outdated
@thyal thyal force-pushed the thomas/PAN-2635-file-sharing branch from cbc46cc to 0eb495d Compare June 16, 2026 06:33
@thyal thyal merged commit 1d1998d into main Jun 16, 2026
3 checks passed
@thyal thyal deleted the thomas/PAN-2635-file-sharing branch June 16, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants