Skip to content

Add environment variable for ROS discovery server#3

Merged
Tiryoh merged 4 commits intomainfrom
feature/discovery-server
Aug 11, 2025
Merged

Add environment variable for ROS discovery server#3
Tiryoh merged 4 commits intomainfrom
feature/discovery-server

Conversation

@Tiryoh
Copy link

@Tiryoh Tiryoh commented Aug 4, 2025

Set the ROS_SUPER_CLIENT environment variable to "true" for enabling the discovery server functionality in the CLI.

https://fast-dds.docs.eprosima.com/en/v2.14.5/fastdds/env_vars/env_vars.html?highlight=ros_super_client#ros-super-client

Set the ROS_SUPER_CLIENT environment variable to "true" for enabling the discovery server functionality in the CLI.
@Tiryoh Tiryoh requested a review from Copilot August 4, 2025 08:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds environment variable configuration to enable ROS discovery server functionality in the CLI. The change sets ROS_SUPER_CLIENT to "true" when ROS2 is detected.

  • Sets ROS_SUPER_CLIENT environment variable to enable discovery server mode
  • Only applies when ROS2 is detected via existing is_ros2() check

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Tiryoh Tiryoh requested a review from nshro August 4, 2025 08:39
@nshro
Copy link

nshro commented Aug 6, 2025

@Tiryoh Could you briefly note in the README.md that rtui2 can be used while Discovery Server setting is enabled? If this is only supported on FastDDS, please mention about that as well. Thanks!

Copy link

@nshro nshro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tiryoh Tiryoh merged commit db42d83 into main Aug 11, 2025
4 checks passed
@Tiryoh Tiryoh deleted the feature/discovery-server branch August 11, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants