Skip to content

Feat: display Node, Topic counts in ROS domain#5

Merged
nshro merged 4 commits intomainfrom
feature/count-node-topic-number
Oct 28, 2025
Merged

Feat: display Node, Topic counts in ROS domain#5
nshro merged 4 commits intomainfrom
feature/count-node-topic-number

Conversation

@nshro
Copy link

@nshro nshro commented Oct 24, 2025

Overview

This PR enhances the RosEntityListPanel widget to display element counts in the tree view, providing better visibility into the number of ROS entities at each level of the hierarchy.

Highlights

  • Top-level count display: Root nodes (e.g., "Node", "Topic") now show the total count of all entities in parentheses
  • Group-level count display: Each group node displays the count of its direct child elements
  • Hierarchical counting: Counts are calculated independently at each level without including parent counts

Notes

  • The counting logic distinguishes between total counts (for root nodes) and group-specific counts (for group nodes)
Node (6)
├── group1 (3)
│   ├── child1
│   ├── child2
│   └── child3
├── group2 (2)
│   ├── child4
│   └── child5
└── group3 (1)
    └── child6

@nshro nshro requested a review from Copilot October 24, 2025 07:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds count indicators to the ROS entity tree view, showing the total number of entities at the root level and individual counts for each group. The implementation calculates counts for grouped entities and displays them in parentheses next to node labels.

  • Adds display of total entity count at root level (e.g., "Node (6)")
  • Shows group-specific counts for each group node (e.g., "group1 (3)")
  • Implements counting logic using dictionaries to track entities per group

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nshro nshro requested a review from Tiryoh October 24, 2025 08:50
Copy link

@Tiryoh Tiryoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nshro nshro merged commit ef6d4aa into main Oct 28, 2025
4 checks passed
@nshro nshro deleted the feature/count-node-topic-number branch October 28, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants