Skip to content

Commit bf070d2

Browse files
faisaletagwerker
andauthored
[FOR DISCUSSION] continue-on-error for ruby-head, jruby (#533)
* continue-on-error for ruby-head, jruby * force failure in HEAD * movie continue-on-error to step level --------- Co-authored-by: Ernesto Tagwerker <[email protected]>
1 parent 0d6a2f8 commit bf070d2

File tree

2 files changed

+1
-16
lines changed

2 files changed

+1
-16
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ jobs:
2424
needs: pre_job # skip duplicates
2525
if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
2626
runs-on: ubuntu-latest
27-
continue-on-error: ${{ matrix.experimental }}
2827
strategy:
2928
fail-fast: false
3029
matrix:
@@ -49,6 +48,7 @@ jobs:
4948
cache-version: 1
5049
- name: Run Cucumber
5150
run: bundle exec cucumber features --format progress --color
51+
continue-on-error: ${{ matrix.experimental }}
5252

5353
Rubocop:
5454
needs: pre_job # skip duplicates

features/support/env.rb

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,5 @@
11
# frozen_string_literal: true
22

3-
if RUBY_VERSION == '3.5.0' && RUBY_PATCHLEVEL == -1
4-
module Cucumber
5-
module Core
6-
module Test
7-
module Location
8-
singleton_class.send(:alias_method, :original_from_source_location, :from_source_location)
9-
def self.from_source_location(file, start_line, _start_column = nil, _end_line = nil, _end_column = nil)
10-
original_from_source_location(file, start_line)
11-
end
12-
end
13-
end
14-
end
15-
end
16-
end
17-
183
require_relative '../../lib/rubycritic'
194
require_relative '../../lib/rubycritic/cli/application'
205
require_relative '../../lib/rubycritic/commands/status_reporter'

0 commit comments

Comments
 (0)