Skip to content

Conversation

@faisal
Copy link
Contributor

@faisal faisal commented Jun 2, 2025

Handled more recent rubocop's warnings:

  • Add blank lines to test cases
  • Rename some predicate methods to the ? form in several places
  • Change string interpolation style in lib/rubycritic/rake_task.rb
  • Suppress remaining warnings

Check list:

@faisal faisal force-pushed the rubocop_blank_lines branch 2 times, most recently from bf256dd to 536184b Compare June 4, 2025 11:54
@faisal faisal changed the title Apply rubocop-suggested blank lines. Apply fixes or suppress warnings for issues spotted by recent rubocop versions. Jun 4, 2025
@faisal
Copy link
Contributor Author

faisal commented Jun 5, 2025

@etagwerker @nunosilva800 what do you think of:

  1. Landing this and monkeypatch cucumber-core to handle Ruby 3.5 method signatures #518 to get back to green on non-jruby things that should pass
  2. Landing Bump aruba, byebug, cucumber, fakefs, rake, reek dependencies #524 to bring dependencies up to current gems
  3. Landing some version (TBD) of show green check mark even if ruby-head fails  #508 + Split experimental steps #517 to keep JRuby test failures from blocking merges.
  4. Landing Remove support for Ruby 3.1 and aligned JRuby 9.4 #514 to finally drop support for the EOL'd Ruby 3.1 and JRuby 9.x.

and then, when there's a new Cucumber that fixes the underlying issue:

  1. Reverting monkeypatch cucumber-core to handle Ruby 3.5 method signatures #518 so we aren't hacking around some other Gem's bugs.

Seperately we'll need to address #513, and I have some clues but haven't dug in fully.

@faisal faisal force-pushed the rubocop_blank_lines branch from 536184b to 79282f1 Compare June 20, 2025 09:43
@faisal faisal closed this Jun 28, 2025
@faisal faisal deleted the rubocop_blank_lines branch July 29, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant