php8 compatibility #106
Merged
php8 compatibility #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@widmogrod would be cool if you can have a look ✌️ |
Owner
|
Hi @nick-zh , please give me some time I have to catchup to PHP8 changes. I will go back to you by the end of this week |
Contributor
Author
|
@widmogrod yes sure thing no worries, thx for the update 👍 |
Owner
|
Hi @nick-zh I fork your change into this feature branch #107 There is few other changes necessary to make this change work with PHP8, and unfortunately not all dev dependencies are ready. I will experiment there to see what changes I need to introduce to enable PHP8 continuous integration. I will keep you updated. Last' but not least, thank you for your contribution! and reminding me about this quite a big PHP release coming up soon! |
Owner
|
@nick-zh Thank you for your contribution! |
Owner
|
New tag 6.0.0 released |
Contributor
Author
|
Awesome, thx a lot 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP8
matchis a reserved keyword