Compose language list design #5375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- creates a new viewModel, then transfer and adapt the code from the existing ViewModel to work properly withing the Compose architecture - adds compose ui for LanguagesListActivity
- adds search functionality
- ui/code fixes - adds P style to Compose Typography
…th search action call back - code/logic/ui fixes - adds click events for list items
- renames some classes
- adds a padding that will respect the keyboard visibility when showing no languages found text
Williamrai
added
Ready to merge
# Conflicts: # app/src/main/java/org/wikipedia/compose/theme/WikipediaTheme.kt
# Conflicts: # app/src/main/java/org/wikipedia/compose/components/WikiTopAppBar.kt
cooltey
requested changes
Mar 13, 2025
There was a problem hiding this comment.
Some issues:
- For the package name
addLanguagesList, since we are using all lower cases logic in the app, I think we can rename it toaddlanguages - When showing the search empty view, the search empty view should not be overlapped by the virtual keyboard. Is there a way to prevent it?
app/src/main/java/org/wikipedia/language/addLanguagesList/AddLanguagesListActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/wikipedia/language/addLanguagesList/AddLanguagesListScreen.kt
Outdated
Show resolved
Hide resolved
| Text( | ||
| text = localizedLanguageName, | ||
| style = WikipediaTheme.typography.h3.copy( | ||
| color = WikipediaTheme.colors.primaryColor, |
There was a problem hiding this comment.
The localized name should be Bold
There was a problem hiding this comment.
it is using style="@style/H3.MaterialListTitle" in XML.
There was a problem hiding this comment.
I see. I just checked the code an the h3 should use bold for the fontWeight.
app/src/main/java/org/wikipedia/language/addLanguagesList/AddLanguagesViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/wikipedia/language/addLanguagesList/AddLanguagesViewModel.kt
Outdated
Show resolved
Hide resolved
| data class LanguageListUiState( | ||
| val searchTerm: String = "", | ||
| val languagesItems: List<LanguageListItem> = emptyList(), | ||
| val error: String? = null, |
There was a problem hiding this comment.
Will you add the WikiErrorView to handle this error message?
There was a problem hiding this comment.
I did not include this because XML did not had this. Should i include this?
There was a problem hiding this comment.
It's fine for this PR but good for a follow-up to add it to keep a good practice.
# Conflicts: # app/src/main/java/org/wikipedia/compose/components/SearchTopAppBar.kt # app/src/main/java/org/wikipedia/compose/components/WikiTopAppBarWithSearch.kt
* - adds a sealed interface approach to handle state - adds a debounce for search - code/ui fixes * - adds coil library - creates an image service interface and implementation - code fixes
- updates compose view model to use simple states
cooltey
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Converts LanguagesListActivity to compose
Phabricator:
https://phabricator.wikimedia.org/T386528