Title Edit / Edit Description#5235
Merged
tonisevener merged 11 commits intotemp-accountsfrom Apr 2, 2025
Merged
Conversation
l-olson1214
requested review from
a team and
mazevedofs
and removed request for
a team
l-olson1214
changed the title
tonisevener
reviewed
Mar 31, 2025
Collaborator
tonisevener
left a comment
tonisevener
left a comment
There was a problem hiding this comment.
@l-olson1214 I have a couple of behavioral questions:
My understanding of the requirements are that the temp accounts sheet component should display after tapping "Edit article description":
I also expect this view to display when tapping "Read more" in the toast:
I'm not seeing it act this way in the PR. If these changes already passed design review, then you can ignore this feedback, just be sure QA is aware of the change or else it will bounce back.
# Conflicts: # WMF Framework/CommonStrings.swift # Wikipedia/Code/ArticleViewController+Editing.swift # Wikipedia/Code/TempAccountSheetCoordinator.swift # Wikipedia/iOS Native Localizations/en.lproj/Localizable.strings
tonisevener
requested changes
Apr 2, 2025
# Conflicts: # Wikipedia/Code/EditSaveViewController.swift
tonisevener
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T340790
Notes
Test Steps
Screenshots/Videos
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-03-31.at.11.15.05.mp4