Skip to content

Conversation

@thecubed
Copy link

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the drain event is never emitted?

@thecubed
Copy link
Author

I believe if the 'drain' event isn't emitted by the Redis library that the logger will hang until Redis's queue is empty. This would prevent messages from being dropped that were queued when the log.close() method is called.

I can check and see if there's a way to have Winston pass a value along to us that allows for force closing the connection by default or to wait for the drain event and close gracefully if set.

@yads
Copy link
Contributor

yads commented Dec 11, 2015

@thecubed I think that would be preferable, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants