Make Witchcraft.Chain.do_notation respect chainer#118
Open
florius0 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Moreover, the fact mention above can be proved as follows. Running this snippet before would've returned async [] do
let a = 1
let b = 2
return a + b
return Process.info(self, :links)
endNow, it shows that the process is indeed linked: |
Contributor
Author
|
@QuinnWilton could you take a look? |
|
Wow, thanks for the PR, @florius0 I'll review it shortly and incorporate into doma-engineering fork and provide feedback here + at fission discord. 💙 💛 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
Witchcraft.Chain.do_notation/2.Previously it ignored second argument assuming any
chainerisWitchcraft.Chain.chain/2.However, there is a call of
do_notation/2across Witchcraft codebase in whichchainerother thenchain/2is passed:witchcraft/lib/witchcraft/monad.ex
Lines 284 to 287 in 6c61c3e
Test plan (required)
mix testshould be enoughClosing issues
Fixes #108
After Merge