Skip to content

fix(assets): add AbortSignal timeout to remote image fetch #17639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bunlongheng wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix(assets): add AbortSignal timeout to remote image fetch #17639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/astro/src/assets/utils/redirectValidation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export async function fetchWithRedirects(options: FetchRedirectOptions): Promise

const urlString = typeof url === 'string' ? url : url.toString();
const req = new Request(url, { headers });
const res = await fetchFn(req, { redirect: 'manual' });
const res = await fetchFn(req, { redirect: 'manual', signal: AbortSignal.timeout(10_000) });

// Handle redirects (301, 302, 303, 307, 308 are actual redirects, not 304 Not Modified)
if ([301, 302, 303, 307, 308].includes(res.status)) {
Expand Down
Loading