Support importing .apng files - #17710
Open
lazerg wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 541a6bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 420 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
The Windows integrations job hung during the build step and got canceled after 35 minutes. This does not relate to my change. Every other Windows job in this run passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
'apng'toVALID_INPUT_FORMATSandVALID_SUPPORTED_FORMATSinpackages/astro/src/assets/consts.ts, and a matchingdeclare module '*.apng'block inpackages/astro/client.d.ts, mirroring the existing.pngentries. Without these, Vite's asset plugin never intercepts.apngimports, so they fall through as generic static assets (a data URI) instead of going through the image pipeline asImageMetadata, and TypeScript reportsCannot find module ... ts(2307)on the import itself.Closes #17709
Testing
test/units/content-collections/image-references.test.tsassertingimageSrcToImportIdresolves an.apngpath, which exercises theVALID_INPUT_FORMATScheck directly.pnpm run test:unit) locally: all pre-existing tests still pass.Docs
No docs changes needed.
.apngnow behaves exactly like the other already-documented raster formats (.png,.gif, etc.).