-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: add explanation for Prettier plugin order to Editor setup page #11688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, and thank you for jumping on this issue!
Just had one small comment about the code comment line. Maybe we can get that shorter?
{ | ||
"plugins": [ | ||
"prettier-plugin-astro", | ||
"prettier-plugin-tailwindcss" // needs to appear after other Prettier plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"prettier-plugin-tailwindcss" // needs to appear after other Prettier plugins | |
"prettier-plugin-tailwindcss" // needs to be last |
Something shorter here would avoid any horizontal scroll on the code snippet!
If this is a prettier file, and this is the plugins
section, is there anything other than a Prettier plugin that could be listed here? Maybe we don't need to be so specific?
Looks like we all got busy, @anaxite ! 😂 I did leave a quick comment, which big if true! (If true, I think it's better?) Otherwise, this one really should be able to get done, so let me know about that comment, and we'll get it merged in! 🙌 |
Description
This change adds an extra step to the Prettier setup instructions of
editor-setup.mdx
. The extra step discusses adding other Prettier plugins, making sure to mention the importance of their order. There is an example that specifically showsprettier-plugin-tailwindcss
as the last one.I went with an extra step to avoid cluttering step 2, and to try keeping concepts separate.
Related issues & labels
improve or update documentation