Conversation
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
autofix.ci
...ebugger.astro_vue__debugger.vue_svelte__debugger.svelte_nextjs__[[..rest]]__debugger.ts.snap
Show resolved
Hide resolved
|
|
||
| ! eslint(no-debugger): `debugger` statement is not allowed | ||
| ,-[fixtures/astro/debugger.astro:11:3] | ||
| 10 | <script asdf > |
There was a problem hiding this comment.
Need to change script handling to match current compiler, we should still parse as JS if there's attributes unless they're type="something" we don't know.
There was a problem hiding this comment.
Not sure if this is the same issue or something else now.
apps/oxlint/src/lsp/snapshots/fixtures_lsp_issue_14565@foo-bar.astro.snap
Show resolved
Hide resolved
| 16 | <script> | ||
| ! eslint(no-unused-vars): Variable 'unusedVariable2' is declared but never used. Unused variables should start with a '_'. | ||
| ,-[test.astro:18:7] | ||
| 17 | // eslint-disable-next-line no-unused-vars |
There was a problem hiding this comment.
Seems like those comments don't work anymore, they're probably at the wrong offset if I were to guess.
crates/oxc_codegen/tests/integration/snapshots/stacktrace_is_correct.snap
Outdated
Show resolved
Hide resolved
feat: a working Astro -> JS transformer
crates/oxc_ast/src/ast/comment.rs
Outdated
| /// HTML comment `<!-- ... -->` | ||
| /// Used in Astro files | ||
| #[estree(rename = "Html")] | ||
| Html = 3, |
There was a problem hiding this comment.
I ended up adding HTML comments as a Astro element instead of a comment type, because I thought I couldn't print trivias, but reading through some more code it seems like you can somehow, so perhaps it could've stayed a trivia to avoid parsing changes. To investigate
| p.print_str("<!doctype "); | ||
| p.print_str(doctype.value.as_str()); | ||
| p.print_str(">"); |
There was a problem hiding this comment.
Should probably be also in a print method on the type
crates/oxc_codegen/tests/integration/snapshots/stacktrace_is_correct.snap.new
Outdated
Show resolved
Hide resolved
| mut out_sections: Option<&mut SectionContents<'a>>, | ||
| ) -> SmallVec<[Result<ResolvedModuleRecord, Vec<OxcDiagnostic>>; 1]> { | ||
| // Special handling for Astro files - use full AST parsing | ||
| #[cfg(feature = "astro")] |
There was a problem hiding this comment.
Maybe this doesn't need to be here since Astro is natively supported? This function seems to be about partial languages
2 participants
No description provided.