Add exists option to ProductSearch Result for matching other search types#641
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
wixbot
added a commit
to wixtoolset/.github
that referenced
this pull request
May 26, 2025
Member
|
Please open an issue so it can go through triage for approval. |
robmen
requested changes
Jun 18, 2025
Member
robmen
left a comment
robmen
left a comment
There was a problem hiding this comment.
This is a pretty good code change. Thanks.
I'd like to see a test added as well to make sure we don't regress this behavior.
metsma
force-pushed
the
ProductSearchExists
branch
2 times, most recently
from
a5496b4 to
17b965b
Compare
(e.g. FileSearch, DirectorySearch, RegistrySearch) Signed-off-by: Raul Metsma <raul@metsma.ee>
robmen
force-pushed
the
ProductSearchExists
branch
from
17b965b to
d96439f
Compare
robmen
approved these changes
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(e.g. FileSearch, DirectorySearch, RegistrySearch)
Closes wixtoolset/issues#9079
Signed-off-by: Raul Metsma raul@metsma.ee