Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type in put_nb_static_property stubgen #990

Closed
wants to merge 1 commit into from

Conversation

mrexodia
Copy link

@mrexodia mrexodia commented Apr 4, 2025

This was generating invalid .pyi files with code like this:

nb::class_<NbDatabase>(m, "Database")
	.def_prop_ro_static("current", &NbDatabase::get_current, "Get the current database")

Actually I think this might be a missing static_assert in def_prop_ro_static because my getter has this signature:

static NbDatabase get_current();

@wjakob
Copy link
Owner

wjakob commented Apr 7, 2025

@mrexodia This is breaking the test suite. Could you instead create an issue with a self-contained reproducer demonstrating the problem you encountered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants