Skip to content

Update: ensure correct file extension for Google exports in download_folder #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devbm7 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

Update: ensure correct file extension for Google exports in download_folder #405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f31a9f
Update: ensure correct file extension for Google exports in download_…
devbm7 Jul 21, 2025
d8816f3
update: ensure correct file extension for Google exports in download_…
devbm7 Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion gdown/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,19 @@ def download(
if filename_from_url is None:
filename_from_url = osp.basename(url)

# If the file is a Google export and output is a path without extension, append the correct extension
export_exts = {'.docx', '.xlsx', '.pptx', '.pdf', '.csv', '.txt', '.ods', '.tsv', '.zip'}
ext_from_filename = osp.splitext(filename_from_url)[1]
if output is None:
output = filename_from_url

output_is_path = isinstance(output, str)
if output_is_path and output.endswith(osp.sep):
if not osp.exists(output):
os.makedirs(output)
output = osp.join(output, filename_from_url)
# If output is a file path, does not already have the export extension, and the filename_from_url does, append it
if output_is_path and ext_from_filename in export_exts and not output.endswith(ext_from_filename):
output += ext_from_filename

if output_is_path:
if resume and os.path.isfile(output):
Expand Down