-
Notifications
You must be signed in to change notification settings - Fork 346
Add clarification for auto-calculate white channel option #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcone
wants to merge
1
commit into
wled:main
Choose a base branch
from
marcone:patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true for any mode, not just Max. Perhaps move it out of the spreadsheet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned this here because "Max" is the only option where it specifically says that it is "good for white-only LEDs". Or are you saying that the part about it being good for white-only LEDs should be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem obsessed with "white only". 😄 Sorry, no offense intended.
Any option is good (or possible) for "white only", depending on what you need or want (or what your external devices expect, yes don't forget that).
I'm saying that choosing anything but "None" will treat your output as RGB and not RGBW or W.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm just trying to understand. As a new user, it is confusing to me to see a full RGB color picker when I only have plain white LEDs connected, have set all the outputs to be white, and chosen the white handling option that is documented to be good for white-only LEDs. I can't imagine I'm the only person in the whole world who is confused by this, so I'm trying to figure it out and hopefully update the documentation so it's more clear to other new users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What further adds to the confusion is that if I set the first 3 outputs to "None" and the 4th output to "Max", I don't get the color wheel, but if I set any of the other outputs to "Max" then I do get the color wheel. That seems like an actual bug to me. This is with the build you asked me to try the other day though, so maybe it's related to that. I can try one of the stable builds if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI adapts to the main segment. Any segment can be main and it is distinguished by a lighter gray in UI. Also affecting UI are selected segments (the ones with checkmark).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have one segment, which contains all 4 outputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then you have your answer. If one of the outputs is RGB (as when Auto white is enabled) UI will respond as segment being RGBW, separate outputs into segments and you'll have control individually.
You can automatically create segments from outputs using selection box in settings.
Please continue discussion either on forum or on Discord.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Perhaps I didn't explain myself well. I have 4 outputs, all in the same segment, all "PWM White". If I set the "Auto-calculate W channel from RGB" option for each of them like so:
0 : None
1 : None
2 : None
3 : Max
then I don't see the color wheel in the color tab, but if I set them e.g. like so:
0 : None
1 : None
2 : Max
3 : None
then I do see the color wheel. Again, all 4 outputs are in the same segment, and I have only one segment.